Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7832: Restored but unopened tabs not added to Recently Closed Tabs #7848

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 8, 2023

Summary of Changes

Adding session tab url fetch and nullable interaction state

This pull request fixes #7832

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Open 2 or more tabs
  2. Fully quit Brave from app switcher
  3. Open Brave
  4. Tap and hold on tab tray button and tap Recently Closed Tabs
  5. Clear list if not empty (not required, but easier to see bug)
  6. Tap and hold on tab button, tap Close All n Tabs
  7. Tap and hold on tab tray button and tap Recently Closed Tabs

Screenshots:

Simulator.Screen.Recording.-.iPhone.14.-.2023-08-08.at.13.24.42.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 8, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner August 8, 2023 17:25
@soner-yuksel soner-yuksel self-assigned this Aug 8, 2023
@soner-yuksel soner-yuksel merged commit e3e5976 into development Aug 8, 2023
@soner-yuksel soner-yuksel deleted the fix/recently-closed-restore branch August 8, 2023 19:04
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restored but unopened tabs not added to Recently Closed Tabs
3 participants